Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fixes #264
Description:
In Go Prompt mode, auto-completion may use the wrong word when the input contains multibyte UTF-8 characters before the cursor.
The completion callback in
cli/terminal.gopassesd.CursorPositionCol()tocompleter.NewCompleter().In go-prompt v0.2.6,
CursorPositionCol()returns a character (rune) index. However,NewCompleter()uses the position to slice a Go string, which requires a byte offset.As a result, Chinese characters before the cursor may cause the input to be truncated at the wrong position, resulting in incorrect completion suggestions.
How do you solve it?
d.CurrentLine().len(d.CurrentLineBeforeCursor()).completer.NewCompleter().This fixes the character-index and byte-index mismatch without changing the existing completion implementation.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
cli/terminal.go.How to verify:
MATCH (v:player) WHERE v.name == "Yao Ming" RET.RET.RETprefix.